Migrate renode test to new container#754
Merged
dgarske merged 4 commits intowolfSSL:masterfrom Apr 29, 2026
Merged
Conversation
Member
danielinux
commented
Apr 16, 2026
danielinux
commented
- fix nRF52 UART
Contributor
There was a problem hiding this comment.
Pull request overview
Migrates Renode-based CI tests to a prebuilt GHCR container image and hardens the Renode update test harness, while also adjusting nRF52 UART TX handling.
Changes:
- Switch Renode CI to pull/run a GHCR-hosted Renode image and add GHCR login/permissions in Renode workflows.
- Improve Renode update test robustness with UART/renode startup timeouts and log capture.
- Adjust nRF52 UART/UARTE initialization and TX buffer handling.
Reviewed changes
Copilot reviewed 14 out of 14 changed files in this pull request and generated 6 comments.
Show a summary per file
| File | Description |
|---|---|
| tools/test-expect-version/test-expect-version.c | Adjusts Linux-only includes used by the UART version probe tool. |
| tools/scripts/renode-test-update.sh | Adds timeouts, readiness checks, and Renode logging for more reliable automated Renode update testing. |
| tools/renode/docker-test.sh | Moves from building a local Docker image to pulling/running a GHCR image for Renode tests. |
| hal/nrf52.c | Updates nRF52 UART/UARTE enable value and uses a static TX buffer for EasyDMA TX. |
| .github/workflows/test-x86-fsp-qemu.yml | Adds apt mirror workaround + retry options to stabilize package installation. |
| .github/workflows/test-build-kontron-vx3060-s2.yml | Adds apt mirror workaround + retry options to stabilize package installation. |
| .github/workflows/test-renode-smallstack.yml | Adds GHCR permissions + login for pulling the Renode container. |
| .github/workflows/test-renode-sha384.yml | Adds GHCR permissions + login for pulling the Renode container. |
| .github/workflows/test-renode-sha3.yml | Adds GHCR permissions + login for pulling the Renode container. |
| .github/workflows/test-renode-nrf52.yml | Adds GHCR permissions + login for pulling the Renode container. |
| .github/workflows/test-renode-noasm.yml | Adds GHCR permissions + login for pulling the Renode container. |
| .github/workflows/test-renode-noasm-smallstack.yml | Adds GHCR permissions + login for pulling the Renode container. |
| .github/workflows/test-renode-fastmath.yml | Adds GHCR permissions + login for pulling the Renode container. |
| .github/workflows/test-renode-fastmath-smallstack.yml | Adds GHCR permissions + login for pulling the Renode container. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
hal/nrf52.c: - Use static volatile buffer for UARTE DMA source instead of stack variable address. GCC 15.2 with -Os optimized away the store to the stack slot, causing the DMA to read zeros. - Set UART0_ENABLE to 4 (UARTE mode) per NRF52840 datasheet. tools/test-expect-version/test-expect-version.c: - Replace deprecated termio.h and linux/serial.h with sys/ioctl.h for compatibility with newer glibc. tools/renode/docker-test.sh: - Remove unused RENODE_CHECKOUT env var. tools/scripts/renode-test-update.sh: - Add robust UART wait functions with timeouts and liveness checks. - Log Renode output to /tmp/renode.log for diagnostics on failure. - Use run_expect_version helper with configurable timeout.
danielinux
force-pushed
the
fix-renode-test
branch
from
602fe82 to
882801e
Compare
danielinux
force-pushed
the
fix-renode-test
branch
from
882801e to
03c38cd
Compare
danielinux
force-pushed
the
fix-renode-test
branch
from
03c38cd to
c0f6b12
Compare
dgarske
approved these changes
Apr 29, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.