fix gles border on nvidia proprietary driver by forcing high prec#177
Open
apewo wants to merge 1 commit intowlrfx:mainfrom
Open
fix gles border on nvidia proprietary driver by forcing high prec#177apewo wants to merge 1 commit intowlrfx:mainfrom
apewo wants to merge 1 commit intowlrfx:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
On nvidia proprietary driver, the border are badly rendered due to medium precision float,
however, forcing high precision float in the fragment shaders and setting the EGL_CONTEXT_CLIENT_VERSION to 3 seems to render the border normally ( tested on : NVIDIA GeForce RTX 2080 / Driver Version: 590.48.01).
To not break compatibility with other gpu, this commit add an option : force_fragment_shader_precision_high , so the default build remain unchanged.
to test :
meson setup -Dscenefx:force_fragment_shader_precision_high=true ...