Skip to content

Fixed opaque black nodes being culled even if effects are used#172

Merged
WillPower3309 merged 1 commit intomainfrom
black-rect-cull-fix
Feb 23, 2026
Merged

Fixed opaque black nodes being culled even if effects are used#172
WillPower3309 merged 1 commit intomainfrom
black-rect-cull-fix

Conversation

@ErikReider
Copy link
Copy Markdown
Member

Supersedes #144
Fixes: WillPower3309/swayfx#448

The issue here is that scene tries to cull fully black rects and scene buffers, but doesn't take into account that these nodes could include additional effects which breaks said culling.

Before:
image

After:
image

@ErikReider ErikReider self-assigned this Feb 23, 2026
@ErikReider ErikReider added the bug Something isn't working label Feb 23, 2026
Copy link
Copy Markdown
Member

@WillPower3309 WillPower3309 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@WillPower3309 WillPower3309 merged commit bb223e3 into main Feb 23, 2026
@WillPower3309 WillPower3309 deleted the black-rect-cull-fix branch February 23, 2026 15:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Setting pure black on titlebars makes things disappear

2 participants