Skip to content

fix(resolver): sass files resolution#15899

Open
ematipico wants to merge 3 commits intomainfrom
fix/sass-resolverr
Open

fix(resolver): sass files resolution#15899
ematipico wants to merge 3 commits intomainfrom
fix/sass-resolverr

Conversation

@ematipico
Copy link
Member

@ematipico ematipico commented Mar 13, 2026

Changes

Closes #15897

I applied a custom resolver solely for CSS files.

Testing

Added a new test

Docs

N/A

@changeset-bot
Copy link

changeset-bot bot commented Mar 13, 2026

🦋 Changeset detected

Latest commit: ff685f2

The changes in this PR will be included in the next version bump.

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions github-actions bot added the pkg: astro Related to the core `astro` package (scope) label Mar 13, 2026
@codspeed-hq
Copy link

codspeed-hq bot commented Mar 13, 2026

Merging this PR will not alter performance

✅ 18 untouched benchmarks


Comparing fix/sass-resolverr (ff685f2) with main (07c1002)

Open in CodSpeed

matthewp
matthewp previously approved these changes Mar 13, 2026
@ematipico
Copy link
Member Author

The CI fails for all runners, but locally this doesn't. I am investigating why

@ematipico ematipico added the pr preview Apply this label to a PR to generate a preview release label Mar 13, 2026
@github-actions github-actions bot removed the pr preview Apply this label to a PR to generate a preview release label Mar 13, 2026
@pkg-pr-new
Copy link

pkg-pr-new bot commented Mar 13, 2026

astro

npm i https://pkg.pr.new/astro@15899

create-astro

npm i https://pkg.pr.new/create-astro@15899

@astrojs/cloudflare

npm i https://pkg.pr.new/@astrojs/cloudflare@15899

@astrojs/preact

npm i https://pkg.pr.new/@astrojs/preact@15899

@astrojs/check

npm i https://pkg.pr.new/@astrojs/check@15899

@astrojs/language-server

npm i https://pkg.pr.new/@astrojs/language-server@15899

astro-vscode

npm i https://pkg.pr.new/astro-vscode@15899

commit: 217e900

@james-yeoman
Copy link

What seems weird is that it seems to pass perfectly fine when using the match option.

cd packages/astro
pnpm test:match tsconfig

passes for both dev and build for the alias-tsconfig test, but

cd packages/astro
pnpm test:integration

passes only on dev, and fails at build for the alias-tsconfig test

@matthewp matthewp dismissed their stale review March 16, 2026 17:01

tests failing.

@matthewp
Copy link
Contributor

Tests failing are legit, those are testing behavior using tsconfig aliases. Not sure exactly why the change breaks them in CI but not locally.

@james-yeoman
Copy link

It failed locally for me though. That was the point of my comment

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

pkg: astro Related to the core `astro` package (scope)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[v6] Sass file resolution no longer respects "baseUrl" in tsconfig.json

3 participants