fix: add ability to pass Babel props to Preact adapter#15862
Open
crutchcorn wants to merge 2 commits intowithastro:mainfrom
Open
fix: add ability to pass Babel props to Preact adapter#15862crutchcorn wants to merge 2 commits intowithastro:mainfrom
crutchcorn wants to merge 2 commits intowithastro:mainfrom
Conversation
🦋 Changeset detectedLatest commit: 701da35 The changes in this PR will be included in the next version bump. Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
This PR adds the ability to pass Babel options to the Preact adapter since the underlying Preact Vite plugin does not support Babel config files: https://github.com/preactjs/preset-vite/blob/main/src/index.ts#L132
Context
When adding Preact to our project, we found that adding an import attribute:
Broke our project with the error:
And the only way we could fix this was to add:
As the Babel options in the Preact plugin.
Testing
This was pulled into the Playful Programming project branch having this issue and validated the fix there.
Docs
No changes should be required to merge this, but happy to write new docs to explain how one can leverage this functionality.