fix(db): read ASTRO_DATABASE_FILE from .env files correctly#15747
Open
7836246 wants to merge 2 commits intowithastro:mainfrom
Open
fix(db): read ASTRO_DATABASE_FILE from .env files correctly#157477836246 wants to merge 2 commits intowithastro:mainfrom
ASTRO_DATABASE_FILE from .env files correctly#157477836246 wants to merge 2 commits intowithastro:mainfrom
Conversation
Fixes withastro#15607 The `databaseFileEnvDefined()` function used Vite's `loadEnv('', process.cwd())` which defaults to only loading `VITE_`-prefixed environment variables. This meant `ASTRO_DATABASE_FILE` set in `.env` files was never detected, causing a false error during `astro build`. The fix reuses the existing `getAstroEnv()` utility which correctly passes the `'ASTRO_'` prefix to `loadEnv()`, consistent with how other parts of the `@astrojs/db` package load environment variables.
🦋 Changeset detectedLatest commit: 7f46ecc The changes in this PR will be included in the next version bump. Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #15607
The
databaseFileEnvDefined()function used Vite'sloadEnv('', process.cwd())which defaults to only loadingVITE_-prefixed environment variables. This meantASTRO_DATABASE_FILEset in.envfiles was never detected, causing a false error duringastro build.The fix reuses the existing
getAstroEnv()utility which correctly passes the'ASTRO_'prefix toloadEnv(), consistent with how other parts of the@astrojs/dbpackage load environment variables.Changes
pnpm changeset.Testing
Docs