Skip to content

feat: file/folder validation(WPB-23623)#20902

Merged
zskhan merged 3 commits intodevfrom
feat/file-folder-validation-WPB-23623
Apr 1, 2026
Merged

feat: file/folder validation(WPB-23623)#20902
zskhan merged 3 commits intodevfrom
feat/file-folder-validation-WPB-23623

Conversation

@arjita-mitra
Copy link
Copy Markdown
Contributor

@arjita-mitra arjita-mitra commented Mar 31, 2026

TaskWPB-23623 [Web] Consolidate File & Folder Name Validation Rules to avoid Android Crash and App issues

Summary

Description
Implement consistent validation rules for file and folder names for upload + rename + creation

Rules
Disallow characters: \ , /and "

Reject names starting with .

Reject name equal to .

Allow . elsewhere in names (e.g., file.txt, my.folder)

Name should be under 64 characters


Security Checklist (required)

  • External inputs are validated & sanitized on client and/or server where applicable.
  • API responses are validated; unexpected shapes are handled safely (fallbacks or errors).
  • No unsafe HTML is rendered; if unavoidable, sanitization is applied and documented where it happens.
  • Injection risks (XSS/SQL/command) are prevented via safe APIs and/or escaping.

Accessibility (required)

Standards Acknowledgement (required)


Screenshots or demo (if the user interface changed)

Notes for reviewers

  • Trade-offs:
  • Follow-ups (linked issues):
  • Linked PRs (e.g. web-packages):

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Mar 31, 2026

🔗 Download Full Report Artifact

🧪 Playwright Test Summary

  • Passed: 14
  • Failed: 0
  • Skipped: 0
  • 🔁 Flaky: 0
  • 📊 Total: 14
  • Total Runtime: 454.4s (~ 7 min 34 sec)

@arjita-mitra arjita-mitra force-pushed the feat/file-folder-validation-WPB-23623 branch from 22f7dd8 to 2ebd299 Compare April 1, 2026 09:03
@sonarqubecloud
Copy link
Copy Markdown

sonarqubecloud bot commented Apr 1, 2026

Quality Gate Failed Quality Gate failed

Failed conditions
18.3% Duplication on New Code (required ≤ 5%)

See analysis details on SonarQube Cloud

@zskhan zskhan added this pull request to the merge queue Apr 1, 2026
Merged via the queue into dev with commit 42f4ad9 Apr 1, 2026
84 of 85 checks passed
@zskhan zskhan deleted the feat/file-folder-validation-WPB-23623 branch April 1, 2026 10:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants