chore: optimize critical flow tests runner [WPB-17563]#20866
chore: optimize critical flow tests runner [WPB-17563]#20866
Conversation
|
🔗 Download Full Report Artifact 🧪 Playwright Test Summary
specs/CriticalFlow/accountManagement-TC-8639.spec.ts (❌ 0 failed,
|
|
| ls -la $HOME/.local/bin/op | ||
| echo "=== All paths verified ===" | ||
|
|
||
| - name: Cache dependencies for test shards |
There was a problem hiding this comment.
I'm not convinced the dependency caching is a good tradeoff here. The 64 Playwright shards do make repeated setup expensive, so I agree with the goal of avoiding 64 separate dependency installs. My concern is with the mechanism, not the optimization target.
Because the cache key includes github.run_id, this is not really a reusable cache across workflow runs. We save a large dependency tree once, restore it many times within the same run, and then delete it again. That makes actions/cache behave more like an intra-run artifact transport than a true cache.
That adds complexity and fragility around node_modules, Playwright binaries, and the 1Password CLI. The follow-up fixes below in this branch makes that brittleness already showing up.
So I'm not arguing against reducing repeated setup for 64 shards. I'm arguing that this implementation may be the wrong tradeoff.



Summary
Optimize critical flow tests runner.
Security Checklist (required)
Accessibility (required)
Standards Acknowledgement (required)
Screenshots or demo (if the user interface changed)
Notes for reviewers