feat(WPB-23950): handle account deep links in-app#20842
Open
JacquelineLehner wants to merge 5 commits intodevfrom
Open
feat(WPB-23950): handle account deep links in-app#20842JacquelineLehner wants to merge 5 commits intodevfrom
JacquelineLehner wants to merge 5 commits intodevfrom
Conversation
Contributor
|
🔗 Download Full Report Artifact 🧪 Playwright Test Summary
|
JacquelineLehner
force-pushed
the
WPB-23950-deep-link-handling
branch
2 times, most recently
from
8de0f83 to
3277e44
Compare
JacquelineLehner
requested review from
V-Gira,
arjita-mitra,
e-maad,
nkaramarko,
otto-the-bot,
screendriver,
thisisamir98 and
zskhan
as code owners
zhannach
previously approved these changes
Mar 27, 2026
zskhan
reviewed
Mar 30, 2026
apps/webapp/src/script/components/Conversation/Conversation.tsx
Outdated
Show resolved
Hide resolved
apps/webapp/src/script/components/Conversation/Conversation.tsx
Outdated
Show resolved
Hide resolved
Intercept Wire account deep links from chat messages and resolve them in-app instead of opening them as external links in a new tab. - add parseAccountDeepLink.ts helper for deep link detection - support user-profile and conversation-join deep links - parse qualified user ids from profile links - reuse current session by opening supported links in-app - keep external link modal flow for unsupported links
Add tests for parseAccountDeepLink covering user-profile and conversation-join links, explicit domain handling, unsupported origins, and missing parameters.
…licitly Move async profile deep link handling into a dedicated helper to remove the inline IIFE in Conversation.tsx. Also handle UserError.TYPE.USER_NOT_FOUND explicitly by logging it instead of swallowing the error.
JacquelineLehner
force-pushed
the
WPB-23950-deep-link-handling
branch
from
3277e44 to
24ff011
Compare
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Security Checklist (required)
Accessibility (required)
Standards Acknowledgement (required)