feat: leave subConversation on error during MLS conference join [WPB-23723]#20727
Open
feat: leave subConversation on error during MLS conference join [WPB-23723]#20727
Conversation
…ut rejecting calls.
zskhan
requested review from
V-Gira,
arjita-mitra,
e-maad,
mathias-niboulies,
nkaramarko,
otto-the-bot,
screendriver and
thisisamir98
as code owners
zskhan
changed the title
Contributor
|
🔗 Download Full Report Artifact 🧪 Playwright Test Summary
specs/CriticalFlow/accountManagement-TC-8639.spec.ts (❌ 1 failed,
|
e-maad
previously approved these changes
Mar 17, 2026
screendriver
previously approved these changes
Mar 17, 2026
EnricoSchw
requested changes
Mar 18, 2026
apps/webapp/src/script/repositories/calling/CallingRepository.ts
Outdated
Show resolved
Hide resolved
zskhan
commented
Mar 18, 2026
| this.logger.error('Failed answering call', error); | ||
| } | ||
| this.rejectCall(conversation.qualifiedId); | ||
| this.leaveCall(conversation.qualifiedId, LEAVE_CALL_REASON.CONVERSATION_DEGRADED); |
Contributor
Author
There was a problem hiding this comment.
@EnricoSchw which reason we can reuse here?
|
e-maad
approved these changes
Mar 19, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Make independent catch block for JoinMLSConversation and answerCall.
So when there is any error on JoinMLSConversation then it will not reject the calls.
Security Checklist (required)
Accessibility (required)
Standards Acknowledgement (required)
Screenshots or demo (if the user interface changed)
Notes for reviewers