Skip to content

Add support for envoy gateway#5150

Open
smatting wants to merge 64 commits intodevelopfrom
WPB-23903-routes-1
Open

Add support for envoy gateway#5150
smatting wants to merge 64 commits intodevelopfrom
WPB-23903-routes-1

Conversation

@smatting
Copy link
Copy Markdown
Contributor

@smatting smatting commented Mar 23, 2026

This PR:

  • Introduces a new Helm chart wire-ingress that targets Envoy Gateway. It is intended as a
    replacement for the nginx-ingress-services chart, which uses ingress-nginx.
    The wire-ingress chart is not production-ready yet.

  • Changes the integration test suite: all tests now run against the wire-ingress chart. The
    ingress solution can be selected via the WIRE_INGRESS_MODE environment variable.
    The federation domains change in Envoy mode — see comments in the code.
    Changes to the federator and integration charts are made to accommodate both variants for
    testing. As a consequence, any changes to nginx-ingress-services will be untested once this PR
    is merged. I've added a check integration-setup-federation.sh that prevents any changes to
    nginx-ingress-services to avoid this being overlooked.

  • Changes the temporary filenames used in the integration test suite. This fixes issues with
    filenames that were too long for nginz to handle.

  • Deletes the unused file hack/helmfile-federation-v0.yaml.gotmpl.

  • Add a post-upgrade to all objects needed for testing. This makes running tests on the cluster manually more convenient

Checklist

  • Add a new entry in an appropriate subdirectory of changelog.d
  • Read and follow the PR guidelines

@smatting smatting force-pushed the WPB-23903-routes-1 branch from c4a1b87 to 28aad07 Compare March 23, 2026 13:59
@zebot zebot added the ok-to-test Approved for running tests in CI, overrides not-ok-to-test if both labels exist label Mar 23, 2026
@wartraxx51
Copy link
Copy Markdown

wartraxx51 commented Mar 24, 2026

Naming thing that bugs me across the whole PR, the chart is wire-ingress, the file is ingress-envoy.yaml the route is nginz-websockets. None of thes have any Ingress in them. My point of view, name it like the replacement wire-gateway , gateway-envoy.yaml etc... not blocking when I open a file called ingress-envoy.yaml and the first thing I see is kind: gateway. I have to stop and double check.

@wartraxx51
Copy link
Copy Markdown

A BackendTrafficPolicy is missing for WebSockets, the default timeouts will terminate long-lived connections, I didn't check the default value, https://gateway.envoyproxy.io/latest/api/extension_types/#backendtrafficpolicy

@smatting smatting force-pushed the WPB-23903-routes-1 branch from 8e81e3f to 83b86e7 Compare March 25, 2026 14:02
@smatting
Copy link
Copy Markdown
Contributor Author

Naming thing that bugs me across the whole PR, the chart is wire-ingress, the file is ingress-envoy.yaml the route is nginz-websockets. None of thes have any Ingress in them. My point of view, name it like the replacement wire-gateway , gateway-envoy.yaml etc... not blocking when I open a file called ingress-envoy.yaml and the first thing I see is kind: gateway. I have to stop and double check.

I changed the ingress-envoy.yaml filename. But I couldn't find other occurences. Everywhere the filenames should be <kind>...
Can you please more concrete?

@smatting
Copy link
Copy Markdown
Contributor Author

smatting commented Mar 25, 2026

A BackendTrafficPolicy is missing for WebSockets, the default timeouts will terminate long-lived connections, I didn't check the default value, https://gateway.envoyproxy.io/latest/api/extension_types/#backendtrafficpolicy

Thank you! Added the policy. We need to run QA tests against this on staging to see if it really works

@smatting smatting marked this pull request as ready for review March 25, 2026 14:26
@smatting smatting requested review from a team as code owners March 25, 2026 14:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ok-to-test Approved for running tests in CI, overrides not-ok-to-test if both labels exist

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants