Conversation
c4a1b87 to
28aad07
Compare
|
Naming thing that bugs me across the whole PR, the chart is wire-ingress, the file is ingress-envoy.yaml the route is nginz-websockets. None of thes have any Ingress in them. My point of view, name it like the replacement wire-gateway , gateway-envoy.yaml etc... not blocking when I open a file called ingress-envoy.yaml and the first thing I see is kind: gateway. I have to stop and double check. |
|
A BackendTrafficPolicy is missing for WebSockets, the default timeouts will terminate long-lived connections, I didn't check the default value, https://gateway.envoyproxy.io/latest/api/extension_types/#backendtrafficpolicy |
This makes it possible to update integration test setup during development
this lets the federator throw the appropiate error when a cert is missing. this is what the backend expects
why remove? No integration tests actually cover these ingresses
8e81e3f to
83b86e7
Compare
I changed the |
Thank you! Added the policy. We need to run QA tests against this on staging to see if it really works |
This PR:
Introduces a new Helm chart
wire-ingressthat targets Envoy Gateway. It is intended as areplacement for the
nginx-ingress-serviceschart, which uses ingress-nginx.The
wire-ingresschart is not production-ready yet.Changes the integration test suite: all tests now run against the
wire-ingresschart. Theingress solution can be selected via the
WIRE_INGRESS_MODEenvironment variable.The federation domains change in Envoy mode — see comments in the code.
Changes to the
federatorandintegrationcharts are made to accommodate both variants fortesting. As a consequence, any changes to
nginx-ingress-serviceswill be untested once this PRis merged. I've added a check
integration-setup-federation.shthat prevents any changes tonginx-ingress-servicesto avoid this being overlooked.Changes the temporary filenames used in the integration test suite. This fixes issues with
filenames that were too long for
nginzto handle.Deletes the unused file
hack/helmfile-federation-v0.yaml.gotmpl.Add a
post-upgradeto all objects needed for testing. This makes running tests on the cluster manually more convenientChecklist
changelog.d