xfd: add more logic to AFD "Draftify" option#2342
Closed
NovemLinguae wants to merge 6 commits intomasterfrom
Closed
xfd: add more logic to AFD "Draftify" option#2342NovemLinguae wants to merge 6 commits intomasterfrom
NovemLinguae wants to merge 6 commits intomasterfrom
Conversation
Why
- a recent RFC decided to bring the merging process into the AFD process, instead of placing maintenance tags and using talk pages
What
- add dropdown called "Desired outcome:" with options delete, merge, redirect, and draftify
- add |outcome= to tagging wikicode when merge, redirect, or draftify are selected
- refactor tagging wikicode to not use ternaries (more readable)
Note that Twinkle uses {{subst:Afd}} and {{subst:Afdx}}, not {{subst:Article for deletion/dated}} directly. Those two templates will need to be modified with template editor edit requests. That doesn't need to hold up this patch though.
Example wikicode outputted by this patch:
Delete:
- `{{subst:afd|help=off}}\n`
- `{{subst:afdx|18th|help=off}}\n`
Merge:
- `{{subst:afd|help=off|outcome=merging}}\n`
- `{{subst:afdx|18th|help=off|outcome=merging}}\n`
If you want the params in a different order, let me know.
Related #2335
This is a patch chain, and this patch is number 2. **Earlier patches need to merge first.** The "changed files" tab will include code from earlier patches due to GitHub limitations, until earlier patches are merged and this patch is rebased. Why - #2335 What - add |outcome=draftification to {{Afd notify}} left on user's talk page - pre-fill some draftify text in the AFD reason textarea. the specific verbiage I chose was `I propose '''draftifying''' because `. Changing away from the draftify outcome in the dropdown blanks the reason textarea. - refactor
Member
Author
|
Combining 3 patches into one at #2345 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a patch chain, and this patch is number 2. Earlier patches need to merge first. Then rebase this one to fix the "files changed" tab.
Why
What
I propose '''draftifying''' because.Example text written to user talk:
{{subst:afd notice|1=NovemTest110}} ~~~~{{subst:afd notice|outcome=draftification|order=  (2nd nomination)|1=NovemTest110}} ~~~~