eslint: add rules for no space inside parentheses#2341
Open
NovemLinguae wants to merge 2 commits intomasterfrom
Open
eslint: add rules for no space inside parentheses#2341NovemLinguae wants to merge 2 commits intomasterfrom
NovemLinguae wants to merge 2 commits intomasterfrom
Conversation
I disagree with not putting space inside parentheses. I'd prefer to do space inside parentheses (MediaWiki style) because that is what my muscle memory is now. But I was overruled in #1827 So let's be consistent and enforce no space inside parentheses. This provides efficiency in code review since CI will catch it instead of requiring reviewer bandwidth. I imagine we used to have a rule that did this, but it was probably lost in the conversion to eslint-config-wikimedia. - change eslint rules to: ``` "array-bracket-spacing": ["error", "never"], "computed-property-spacing": ["error", "never"], "space-before-function-paren": ["error", "never"], "space-in-parens": ["error", "never"], "template-curly-spacing": ["error", "never"], ``` - autofix (`npm run lint:fix`)
github-actions
Bot
added
Module: tag
Module: speedy
Module: morebits
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I disagree with not putting space inside parentheses. I'd prefer to do space inside parentheses (MediaWiki style) because that is what my muscle memory is now after years of working on MediaWiki. But I was overruled in #1827
So let's be consistent and enforce no space inside parentheses. This provides efficiency in code review since CI will catch it instead of requiring reviewer bandwidth.
I imagine we used to have a rule that did this, but it was probably lost in the conversion to eslint-config-wikimedia.
npm run lint:fix)