morebits: deprecate methods added to HTMLFormElement prototype#2340
Draft
siddharthvp wants to merge 1 commit intomasterfrom
Draft
morebits: deprecate methods added to HTMLFormElement prototype#2340siddharthvp wants to merge 1 commit intomasterfrom
siddharthvp wants to merge 1 commit intomasterfrom
Conversation
github-actions
Bot
added
Module: tag
Module: speedy
Module: morebits
…totype Add `getChecked` and `getUnchecked` methods to `Morebits.QuickForm` and deprecate them from `HTMLFormElement` prototype. Update usage in modules accordingly. Remove functionality which is not used in Twinkle or any enwiki user scripts: * Getting checked/unchecked values from select fields and single checkboxes. * The `type` parameter. Closes #910
siddharthvp
force-pushed
the
htmlform-prototype
branch
from
b44bded to
231342f
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
morebits: deprecate and simplify methods added to HTMLFormElement prototype
Add
getCheckedandgetUncheckedmethods toMorebits.QuickFormand deprecate them fromHTMLFormElementprototype. Update usage in modules accordingly.Remove functionality which is not used in Twinkle or any enwiki user scripts:
typeparameter.Closes #910