block: rewrite user type options for more modularity + adjust some#2311
Open
IlyasLebleu wants to merge 2 commits intowikimedia-gadgets:masterfrom
Open
block: rewrite user type options for more modularity + adjust some#2311IlyasLebleu wants to merge 2 commits intowikimedia-gadgets:masterfrom
IlyasLebleu wants to merge 2 commits intowikimedia-gadgets:masterfrom
Conversation
… projsocks (ANI moment)
siddharthvp
reviewed
Feb 13, 2026
| sig: null | ||
| }, | ||
| oversightblock: { | ||
| userTypes: ['ip', 'ta', 'named'], |
Member
There was a problem hiding this comment.
I think we can treat this as the default. No need to write it out for every preset.
NovemLinguae
requested changes
Apr 18, 2026
| 'uw-softerblock': { | ||
| userTypes: ['named'], | ||
| expiry: 'infinity', | ||
| forRegisteredOnly: true, |
Member
There was a problem hiding this comment.
Can remove forRegisteredOnly: true here, I think.
| userTypes: ['named'], | ||
| autoblock: true, | ||
| expiry: 'infinity', | ||
| forRegisteredOnly: true, |
Member
There was a problem hiding this comment.
Can remove forRegisteredOnly: true here, I think.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replaced the
forIPsOnly,forTempAccountsOnlyandforRegisteredOnlyby a singleuserTypesarray that can take'ip','ta'and'named'as values, to cover more options without multiplying variables. Allowed me to also fix a few that couldn't be treated previously (such as username blocks not showing for TAs anymore). Tested on test.wikipedia.org, block options menu works exactly as intended.