Skip to content

tag: add parameters to {{R from sort name}} #2290

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
User-IAmChaos wants to merge 3 commits into
base: master
Choose a base branch
from
Open

tag: add parameters to {{R from sort name}} #2290

Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
e2fe30e
I'm still new to github, but is this issue 2281?
User-IAmChaos Jan 3, 2026
a162d62
I think this helps Issue 2281
User-IAmChaos Jan 3, 2026
a22574b
Merge branch 'master' into master
NovemLinguae Apr 18, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 21 additions & 1 deletion src/modules/twinkletag.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1022,7 +1022,27 @@ Twinkle.tag.redirectList = {
{ tag: 'R from more specific name', description: 'redirect from a more specific title to a less specific, more general one' },
{ tag: 'R from non-neutral name', description: 'redirect from a title that contains a non-neutral, pejorative, controversial, or offensive word, phrase, or name' },
{ tag: 'R from short name', description: 'redirect from a title that is a shortened form of a person\'s full name, a book title, or other more complete title' },
{ tag: 'R from sort name', description: 'redirect from the target\'s sort name, such as beginning with their surname rather than given name', restriction: 'insideMainspaceOnly' },
{ tag: 'R from sort name', description: 'redirect from the target\'s sort name, such as beginning with their surname rather than given name', restriction: 'insideMainspaceOnly' ,
Copy link
Copy Markdown
Member

@NovemLinguae NovemLinguae Jan 3, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You have an extra space at the end of this line (the one before the comma) that is causing the "linter" test to fail.

subgroup: [
Copy link
Copy Markdown
Member

@NovemLinguae NovemLinguae Apr 18, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's get tag, description, and restriction on their own lines, since subgroup is on its own line.

{
name: 'sortnamefrom',
type: 'input',
label: 'Sort Name Initial',
tooltip: 'Enter the letter that is being sorted by. This should usually be the first letter of the redirect title'
},
{
name: 'sortnameto',
type: 'input',
label: 'Page Title Initial',
tooltip: 'Enter the first letter of the target page.'
},
{
name: 'SortName Info',
type: 'div',
label: $.parseHTML('<p>Please provide the required parameters for sort name redirects. See <a href="/wiki/Template:R_from_sort_name#Parameters">the template page for more info</a></p>')
}
]
},
Copy link
Copy Markdown
Member

@NovemLinguae NovemLinguae Apr 18, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't see any code that will change the wikitext once the form information is collected. You'll probably need to pair these form changes with some more code changes farther down, and the farther down code changes will change the output of this tag's wikitext.

{ tag: 'R from synonym', description: 'redirect from a semantic synonym of the target page title' }
],
People: [
Expand Down
Loading