Define ModuleNamespace to ECMA-262 Module Namespace Exotic Object#1483
Open
guybedford wants to merge 1 commit intowhatwg:mainfrom
Open
Define ModuleNamespace to ECMA-262 Module Namespace Exotic Object#1483guybedford wants to merge 1 commit intowhatwg:mainfrom
guybedford wants to merge 1 commit intowhatwg:mainfrom
Conversation
Member
|
This looks okay to me, but the template will have to be filled in. One caveat here I guess is that Wasm JS API bindings are not actually implemented through IDL in (most?) implementations. |
Author
|
Thanks for taking a look and I believe you're right on the implementation aspects. The alternative would be to just use I'll aim to get the Node.js implementation together and post back the template with an update when that's ready. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This came up in a PR addition to the WebAssembly ESM Integration in WebAssembly/esm-integration#104 to have a WebIDL function definition returning a
ModuleNamespaceobject (namespaceInstancebelow):To support this it would be beneficial to have an upstream definition of
ModuleNamespaceto ensure validations are handled at the WebIDL layer for functions taking module namespaces as arguments.The PR has not landed yet, posting this up for initial feedback before the ESM Integration PR lands.
(See WHATWG Working Mode: Changes for more details.)
Preview | Diff