-
-
Notifications
You must be signed in to change notification settings - Fork 611
docs: clarify behavior of importing CSS from JavaScript #1655
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
pranjalisr
wants to merge
6
commits into
webpack:main
Choose a base branch
from
pranjalisr:fix-css1
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from 2 commits
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
d622278
docs: clarify behavior of importing CSS from JavaScript
pranjalisr 4220ff9
docs: address feedback
pranjalisr 0e2e2c3
docs: reviewed feedback
pranjalisr 8822772
Merge branch 'main' into fix-css1
pranjalisr 676801b
docs: clarify behavior
pranjalisr 25609d1
docs: updated
pranjalisr File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Some comments aren't visible on the classic Files Changed page.
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -47,9 +47,15 @@ Then, add the loader to your `webpack` configuration. For example: | |
| **file.js** | ||
|
|
||
| ```js | ||
| import * as css from "file.css"; | ||
| import * as css from "./file.css"; | ||
| ``` | ||
|
|
||
| When using `css-loader`(https://github.com/webpack/css-loader), webpack processes the file through configured [loaders] (https://webpack.js.org/concepts/loaders/) and turns it into a JavaScript module. | ||
|
|
||
| The imported value is not a native `CSSStyleSheet`. Instead, it is a JavaScript module generated by `css-loader`. When CSS Modules are enabled, the import can contain exported identifiers (such as class name mappings) from the CSS file. | ||
|
|
||
| If you only want to apply the styles and do not need to access any exports, you can simply write: | ||
|
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. this doesnt reference anything
Contributor
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. updated to reference imported module clearly |
||
|
|
||
| **webpack.config.js** | ||
|
|
||
| ```js | ||
|
|
||
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In some cases yes, so it is wrong