-
Notifications
You must be signed in to change notification settings - Fork 83
RFC 128: Consume User Activation #128
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 1 commit
Commits
Show all changes
4 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,41 @@ | ||
| # RFC: Consume user activation | ||
|
|
||
| Editor: Marcos Caceres, Apple Inc. | ||
|
|
||
| ## Summary | ||
|
|
||
| Tests in WPT are currently relying on various indirect means to "[consume user activation](https://html.spec.whatwg.org/#consume-user-activation)" [HTML]. | ||
| Some of these means are non-standard in as far as they are not specified to consume user activation, meaning that the tests are inshrining non-standard behavior for conformance purposes. | ||
|
|
||
| The workarounds being used are as follows, with several drawbacks: | ||
|
|
||
| * Using Fullscreen API: non-standard, takes significant time to put an element into fullscreen. | ||
foolip marked this conversation as resolved.
Outdated
Show resolved
Hide resolved
marcoscaceres marked this conversation as resolved.
Outdated
Show resolved
Hide resolved
|
||
| * Using window.open() and window.close() - non-standard, not mobile friendly. | ||
| * Using Payment Request API - not widely implemented (e.g., not exposed in Gecko). | ||
|
|
||
| We also looked at a range of other possible APIs that consume user activation, and found [none to be suitable](https://github.com/web-platform-tests/wpt/issues/36727#issuecomment-1296349964). | ||
|
|
||
| ## Details | ||
|
|
||
| We would like to propose the addition of an async function `test_driver.consume_user_activation()` method that returns a `Promse<boolean>` (representing if the activation was consumed or not). For example: | ||
|
|
||
| ``` | ||
| const consume = await test_driver.consume_user_activation(); | ||
| ``` | ||
|
|
||
| The `consume_user_activation()` method can take a `Window` <var>context</var> (which defaults to the current Window object). Allowing consumption to happen at a particular window, if required. | ||
|
|
||
| The `consume_user_activation()` method would be implemented via the proposed addition of “[Consume user activation of Window](https://github.com/w3c/webdriver/pull/1695)” to the Web Driver specification. | ||
|
|
||
| This prposal has several advantages: | ||
| * it's fast - no opening windows or waiting for fullscreen to enter/exit. | ||
| * it's lightweight - it doesn't create new browsing contexts. | ||
| * it's mobile friendly - as above. | ||
| * it's build for purpose - no more using other APIs to indirectly achieve the desired outcome. | ||
| * It's really simple - it compliments `.bless()` and other user activaton functionality already available. | ||
marcoscaceres marked this conversation as resolved.
Outdated
Show resolved
Hide resolved
|
||
|
|
||
| [An implementation](https://github.com/WebKit/WebKit/pull/6539) is available in WebKit. | ||
|
|
||
| ## Risks | ||
|
|
||
| None known. | ||
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.