Skip to content

fix: retry giveFocus on next animation frame for newly created blocks #3100

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
sawka merged 3 commits into from
Mar 24, 2026
Merged

fix: retry giveFocus on next animation frame for newly created blocks #3100

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
f90d576
fix: retry giveFocus on next animation frame for newly created blocks
majiayu000 Mar 21, 2026
1d42fbc
fix: cancel pending rAF in setFocusTarget on cleanup and re-invocation
majiayu000 Mar 21, 2026
c89126e
fix: guard rAF retry in setFocusTarget with focus containment check
majiayu000 Mar 21, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions frontend/app/block/block.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -226,6 +226,9 @@ const BlockFull = memo(({ nodeModel, viewModel }: FullBlockProps) => {
return;
}
focusElemRef.current?.focus({ preventScroll: true });
requestAnimationFrame(() => {
viewModel?.giveFocus?.();
});
}, [viewModel]);

const focusFromPointerEnter = useCallback(
Expand Down