Open
Conversation
Collaborator
Author
|
Ian would like us to get our cookie code and GDPR messaging in order. He would like at least one other Torchbox person to review my work before we consider pushing this PR. @thibaudcolas or @zerolab do either of you have some availability coming up soon? |
vossisboss
added
the
needs-extra-review
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR contains updated cookie code that provides users with an option to opt in or opt out of our analytics tracking. This code will be more compliant with GDPR and will work with the new consent code that Google Analytics is providing.
We are going to be testing this code on staging first over the end-of-year holidays to make sure that these changes don't wreck the analytics we are currently relying on. This PR will be staying in the queue until then.