Added support for SynchronizedField on ManyToManyFields#891
Added support for SynchronizedField on ManyToManyFields#891tognee wants to merge 2 commits intowagtail:mainfrom
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #891 +/- ##
==========================================
+ Coverage 93.02% 93.04% +0.01%
==========================================
Files 47 47
Lines 4245 4257 +12
Branches 551 552 +1
==========================================
+ Hits 3949 3961 +12
Misses 177 177
Partials 119 119 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
I've seen that bitnami moved all free postgresql images to bitnamilegacy. I changed it just to test the checks, but I think it could it be replaced with the official docker postgresql image |
Marvinrose
left a comment
There was a problem hiding this comment.
The codecov report flags one missing line in test/models.py, worth checking which line isn't covered and adding a test case for it.
The bitnamilegacy image change in test.yml makes sense as a short-term fix, but as you noted it might be worth replacing with the official postgres Docker image for long-term stability.
2d94e37 to
b0d9633
Compare
b0d9633 to
fe388cf
Compare
|
@Marvinrose I've aligned to main and added a test for the |
This PR lets users set a ManyToManyField as a SynchronizedField without recieving the error:
This does not solve the issue of whether a ManyToMany field should be translatable or syncronized, but gives the option for the user to syncronize it without errors.
This PR adds: