Conversation
| publish_translations=form.cleaned_data["publish_translations"], | ||
| ) | ||
|
|
||
| self.components.save( |
There was a problem hiding this comment.
With publish+auto-machine-translate we cannot really handle those components, I think. With bulk actions we may add those components to the confirmation view. That's why I have not extracted them into update_translations().
I also don't fully understand them. Are those components meant to be created once per translation request or once per translation source? I know, it's up to the dev, but it would be nice to get some infos on how this has been used so far.
This can be enabled by setting WAGTAILLOCALIZE_UPDATE_TRANSLATIONS_ON_PUBLISH = True Relates to wagtail#789
26da10a to
66eb251
Compare
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #887 +/- ##
==========================================
- Coverage 93.07% 92.39% -0.69%
==========================================
Files 47 47
Lines 4243 4297 +54
Branches 551 564 +13
==========================================
+ Hits 3949 3970 +21
- Misses 175 201 +26
- Partials 119 126 +7 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This only partially implements the proposed changes of #789 (comment) and should be seen as an early draft now open for discussion.
TBD:
EditViewforPage).wagtail.signals.publishedsignal instead of theafter_publish_pagehook (actually this signal could be used for pages too 🤔 )Todo:
Relates to #789