Adds failing test for cleared foreignkey behaviour#744
Draft
alexalligator wants to merge 2 commits intowagtail:mainfrom
Draft
Adds failing test for cleared foreignkey behaviour#744alexalligator wants to merge 2 commits intowagtail:mainfrom
alexalligator wants to merge 2 commits intowagtail:mainfrom
Conversation
Collaborator
|
The tests are failing with as intended to show in the PR |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds a failing test to demonstrate the issue described below.
Ref slack discussion.
Wagtail localize currently skips extracting segments for optional foreign keys that have no instance set. I.e. cleared foreign keys are treated as a lack of meaningful data, rather than
Nonebeing treated as a meaningful value in and of itself.This means that once a page is translated, clearing the field on the source page and retranslating leaves the translation with a value still selected: