Wind direction: circular median over averaging window#1
Draft
w1ndhunter wants to merge 1 commit into
Draft
Conversation
Replace vector mean of unit vectors with median on the 8-sector ring to reduce flip-flopping when the vane jitters between adjacent bins. Keep resultant-length check for low-confidence fallback to wind_direction(). Co-authored-by: Michael Lechner <w1ndhunter@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Wind direction during
wind_speed_and_direction_avgwas computed as a vector mean of per-sample directions, then quantized to 45° sectors. When the vane or ADC jitters between adjacent bins (e.g. W vs NW), the mean can drift and the reported heading can bounce.This change keeps the same confidence check (normalized resultant length over samples) but replaces the final heading with the circular median on the 8-sector ring (indices 0..7): the sector that minimizes the sum of shortest arc distances in 45° steps. Ties favor the bin that appears most often, then the smaller index.
Details
_wind_direction_resultant_from_binsand_circular_median_bin.voltage_to_degreeseachdir_sample_interval_ms; only the aggregation from bin list to reported degrees changed.Testing
No automated tests in repo for MicroPython board code; logic is pure Python and suitable for a quick desktop sanity check of
_circular_median_binif needed.