Skip to content

fix error comparing IPv6 and IPv4 #7

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
phanhai27 wants to merge 1 commit into
base: master
Choose a base branch
from
Open

fix error comparing IPv6 and IPv4 #7

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion src/public_ip/_ip.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,7 @@
import threading
import typing
from queue import Queue
from ipaddress import ip_address, IPv4Address

LOGGER = logging.getLogger(__name__)

Expand Down Expand Up @@ -56,7 +57,10 @@ def get(nurls: int = len(URLS), timeout: float = 1) -> str:

ips = []
while not queue.empty():
ips.append(queue.get())
# Fix error comparing IPv6 and IPv4 (if first_votes == second_votes)
ipx = queue.get()
if type(ip_address(ipx)) is IPv4Address:
ips.append(ipx)

if not ips:
raise IOError("all server queries failed")
Expand Down