Handle objects with null prototypes as topics#411
Draft
strugee wants to merge 2 commits intonewer-nodesfrom
Draft
Handle objects with null prototypes as topics#411strugee wants to merge 2 commits intonewer-nodesfrom
strugee wants to merge 2 commits intonewer-nodesfrom
Conversation
8ebece4 to
19bc1f7
Compare
Member
Author
|
Tests passing locally for me under Node 24 |
19bc1f7 to
bb42279
Compare
Member
Author
|
Rebasing on #413 to get CI coverage of our supported versions. |
9230d9a to
baf4c92
Compare
bd11ed2 to
5dbdadd
Compare
baf4c92 to
eb01ed7
Compare
Member
Author
|
Marking as draft since I'm experiencing related crashes in SeaGL/patch and am unsure if this is a full fix. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See the inline comment - impetus here is that if you
require()an ES6 module, you get an Object with its prototype set tonull, which results in this crash:Because there's no
toStringon the module object, type coercion fails.