[Misc] Relax transformers upper bound to include 5.2.0#36745
[Misc] Relax transformers upper bound to include 5.2.0#36745woforce wants to merge 2 commits intovllm-project:mainfrom
Conversation
Allow vLLM to install in environments that require transformers 5.2.0 while preserving the existing minimum supported version. Signed-off-by: woforce <wangsl@stu.hit.edu.cn> Made-with: Cursor
|
👋 Hi! Thank you for contributing to the vLLM project. 💬 Join our developer Slack at https://slack.vllm.ai to discuss your PR in #pr-reviews, coordinate on features in #feat- channels, or join special interest groups in #sig- channels. Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run You ask your reviewers to trigger select CI tests on top of Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging. To run CI, PR reviewers can either: Add If you have any questions, please reach out to us on Slack at https://slack.vllm.ai. 🚀 |
|
Hi maintainers, |
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request relaxes the upper bound of the transformers dependency to version 5.2.0. While this may improve compatibility in environments requiring newer versions, it introduces a significant risk. The change crosses a major version boundary (<5 to <=5.2.0), which often includes breaking API changes. The pull request lacks a test plan and results to validate that vLLM remains fully compatible with these newer transformers versions. This is a critical concern for the stability of the project.
Note: Security Review has been skipped due to the limited scope of the PR.
| blake3 | ||
| py-cpuinfo | ||
| transformers >= 4.56.0, < 5 | ||
| transformers >= 4.56.0, <= 5.2.0 |
There was a problem hiding this comment.
Relaxing the upper bound for the transformers library from < 5 to <= 5.2.0 is a high-risk change as it crosses a major version boundary. Major versions of libraries often introduce breaking changes that could negatively impact vLLM's functionality and stability.
The pull request description does not provide a test plan or any evidence that vLLM has been thoroughly tested against transformers versions between 5.0.0 and 5.2.0. Without this validation, we cannot be confident that this change will not introduce regressions.
Please add a comprehensive test plan and the corresponding results to demonstrate that vLLM remains fully functional with the newly allowed versions of transformers. If this cannot be provided, it would be safer to revert this change to maintain the project's stability.
There was a problem hiding this comment.
Thanks for the detailed feedback — agreed on the risk of crossing a major-version boundary.
I will add a concrete validation matrix and results for transformers==5.0.0, 5.1.0, and 5.2.0, including:
vLLM install/import checks
offline generation smoke test
OpenAI-compatible server startup + one request
tokenizer/chat-template sanity checks
If any incompatibility is found, I will narrow the upper bound or revert this change.
|
We already have WIP to do this, see #30566 |
|
Closing in favor of #30566 |
2 participants
Allow vLLM to install in environments that require transformers 5.2.0 while preserving the existing minimum supported version.
Made-with: Cursor
Purpose
Test Plan
Test Result
Essential Elements of an Effective PR Description Checklist
supported_models.mdandexamplesfor a new model.