Add Qwen3.5 model support via opt-in dependency extra#154
Closed
ricky-chaoju wants to merge 1 commit intovllm-project:mainfrom
Closed
Add Qwen3.5 model support via opt-in dependency extra#154ricky-chaoju wants to merge 1 commit intovllm-project:mainfrom
ricky-chaoju wants to merge 1 commit intovllm-project:mainfrom
Conversation
Signed-off-by: RickyChen / 陳昭儒 <ricky.chen@infinirc.com>
b0b35a7 to
8c07c3c
Compare
LxYuan0420
reviewed
Mar 11, 2026
Collaborator
LxYuan0420
left a comment
There was a problem hiding this comment.
Thanks for consolidating those PR. The compatibility analysis is useful and we'll reference it.
Closing this PR because:
- transformers>=5.0.0 in an optional extra isn't isolated — it upgrades the entire environment and breaks vLLM 0.14.x + all existing models. Transformers v5 may be fine but we need to verify carefully.
- vLLM upgrade is a project-wide migration, not a per-model opt-in. We're waiting on #134 (@ericcurtin's wheel install) to confirm the macOS path before bumping further.
- Qwen3.5 has ongoing MLX incompatibilities — cache is broken for hybrid architectures (mlx-lm#980, mlx-lm#903), server tool calls fail (mlx-lm#905). Not ready to claim support until upstream stabilizes.
- VLLM_VERSION env var is fragile — default install must always produce a working setup.
- No smoke tests for existing models or end-to-end tests for Qwen3.5.
Suggested approach: Break this into steps: (1) first land the baseline upgrade with smoke tests proving existing models still work, then (2) add Qwen3.5 support once upstream MLX issuesare resolved.
Happy to review a re-scoped version. 🙏
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Enable Qwen3.5 (dense and MoE) model support by adding a
[qwen35]optional dependency extra. Base dependencies unchanged — existing users unaffected.Consolidates and supersedes #121, #123, #129 .
Why the original PRs' runtime fixes are unnecessary
BatchKVCache.offsetasmx.array— batched decode works without fallbackpartial_rotary_factor=0.25, which triggers transformers' built-inset()coercion pathqwen3_5andqwen3_5_moemodulesInstallation