Skip to content

[CI] Remove tranformers version restriction#6122

Closed
Potabk wants to merge 1 commit intovllm-project:mainfrom
Potabk:reqs
Closed

[CI] Remove tranformers version restriction#6122
Potabk wants to merge 1 commit intovllm-project:mainfrom
Potabk:reqs

Conversation

@Potabk
Copy link
Collaborator

@Potabk Potabk commented Jan 22, 2026

What this PR does / why we need it?

Do not limit transformers version. use the version vllm use. and prepare for the coming transformers-v5 vllm-project/vllm#30566

Does this PR introduce any user-facing change?

How was this patch tested?

Signed-off-by: wangli <wangli858794774@gmail.com>
@Potabk Potabk requested a review from wangxiyuan as a code owner January 22, 2026 06:21
@github-actions
Copy link
Contributor

👋 Hi! Thank you for contributing to the vLLM Ascend project. The following points will speed up your PR merge:‌‌

  • A PR should do only one thing, smaller PRs enable faster reviews.
  • Every PR should include unit tests and end-to-end tests ‌to ensure it works and is not broken by other future PRs.
  • Write the commit message by fulfilling the PR description to help reviewer and future developers understand.

If CI fails, you can run linting and testing checks locally according Contributing and Testing.

@Potabk Potabk changed the title [CI] Bump transformers version to 4.57.5 [CI] Remove tranformers version restriction Jan 22, 2026
Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

The pull request removes specific version constraints for the transformers library and also removes the pymarkdown configuration. While the intention to allow vllm to manage the transformers version is noted, its complete removal from the dependency lists could lead to runtime issues if vllm_ascend directly relies on it. Additionally, the removal of pymarkdown configuration might impact the consistency and quality of markdown documentation.

I am having trouble creating individual review comments. Click here to see my feedback.

pyproject.toml (20)

critical

The transformers library has been completely removed from the requires list in pyproject.toml. While the PR description mentions "Do not limit transformers version. use the version vllm use.", if vllm_ascend directly imports and uses transformers, its complete removal from the dependency list could lead to ModuleNotFoundError at runtime. It is generally recommended to declare all direct dependencies, even if unversioned, to ensure they are installed. Consider adding transformers back to the requires list without a version constraint, or with a broad minimum version, if vllm_ascend directly depends on it.

"transformers",

requirements.txt (34)

critical

The transformers library has been completely removed from requirements.txt. Similar to the pyproject.toml change, if vllm_ascend directly relies on transformers, its absence from this file means it won't be installed when requirements.txt is used for environment setup. To ensure transformers is always available, it should be listed, possibly without a version constraint.

transformers

pyproject.toml (36-45)

high

The [tool.pymarkdown] section has been removed, which disables markdown linting for the project. This could lead to inconsistencies in markdown file formatting and quality over time. If markdown quality is important for documentation and readability, consider re-enabling markdown linting or replacing pymarkdown with an alternative.

@github-actions
Copy link
Contributor

This pull request has conflicts, please resolve those before we can evaluate the pull request.

1 similar comment
@github-actions
Copy link
Contributor

This pull request has conflicts, please resolve those before we can evaluate the pull request.

@Potabk Potabk closed this Mar 12, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant