[CI] Remove tranformers version restriction#6122
[CI] Remove tranformers version restriction#6122Potabk wants to merge 1 commit intovllm-project:mainfrom
Conversation
Signed-off-by: wangli <wangli858794774@gmail.com>
|
👋 Hi! Thank you for contributing to the vLLM Ascend project. The following points will speed up your PR merge:
If CI fails, you can run linting and testing checks locally according Contributing and Testing. |
There was a problem hiding this comment.
Code Review
The pull request removes specific version constraints for the transformers library and also removes the pymarkdown configuration. While the intention to allow vllm to manage the transformers version is noted, its complete removal from the dependency lists could lead to runtime issues if vllm_ascend directly relies on it. Additionally, the removal of pymarkdown configuration might impact the consistency and quality of markdown documentation.
I am having trouble creating individual review comments. Click here to see my feedback.
pyproject.toml (20)
The transformers library has been completely removed from the requires list in pyproject.toml. While the PR description mentions "Do not limit transformers version. use the version vllm use.", if vllm_ascend directly imports and uses transformers, its complete removal from the dependency list could lead to ModuleNotFoundError at runtime. It is generally recommended to declare all direct dependencies, even if unversioned, to ensure they are installed. Consider adding transformers back to the requires list without a version constraint, or with a broad minimum version, if vllm_ascend directly depends on it.
"transformers",
requirements.txt (34)
The transformers library has been completely removed from requirements.txt. Similar to the pyproject.toml change, if vllm_ascend directly relies on transformers, its absence from this file means it won't be installed when requirements.txt is used for environment setup. To ensure transformers is always available, it should be listed, possibly without a version constraint.
transformers
pyproject.toml (36-45)
The [tool.pymarkdown] section has been removed, which disables markdown linting for the project. This could lead to inconsistencies in markdown file formatting and quality over time. If markdown quality is important for documentation and readability, consider re-enabling markdown linting or replacing pymarkdown with an alternative.
|
This pull request has conflicts, please resolve those before we can evaluate the pull request. |
1 similar comment
|
This pull request has conflicts, please resolve those before we can evaluate the pull request. |
What this PR does / why we need it?
Do not limit transformers version. use the version vllm use. and prepare for the coming transformers-v5 vllm-project/vllm#30566
Does this PR introduce any user-facing change?
How was this patch tested?