Skip to content

feat: support typescript build mode#9870

Open
lishaduck wants to merge 1 commit intovitest-dev:mainfrom
lishaduck:build-mode
Open

feat: support typescript build mode#9870
lishaduck wants to merge 1 commit intovitest-dev:mainfrom
lishaduck:build-mode

Conversation

@lishaduck
Copy link
Contributor

@lishaduck lishaduck commented Mar 15, 2026 •
edited
Loading

Description

Resolves #9865
Resolves #3752
Supersedes flint-fyi/flint#2427

Please don't delete this checklist! Before submitting the PR, please make sure you do the following:

  • It's really useful if your PR references an issue where it is discussed ahead of time. If the feature is substantial or introduces breaking changes without a discussion, PR might be closed.
  • Ideally, include a test that fails without this PR but passes with it.
  • Please, don't make changes to pnpm-lock.yaml unless you introduce a new test example.
  • Please check Allow edits by maintainers to make review process faster. Note that this option is not available for repositories that are owned by Github organizations.

Tests

  • Run the tests with pnpm test:ci. <-- test:ci failed b/c browser mode, pnpm test mostly passes 🤷🏻‍♂️

Documentation

  • If you introduce new functionality, document it. You can run documentation with pnpm run docs command.

Changesets

  • Changes in changelog are generated from PR name. Please, make sure that it explains your changes in an understandable manner. Please, prefix changeset messages with feat:, fix:, perf:, docs:, or chore:.

@netlify
Copy link

netlify bot commented Mar 16, 2026

✅ Deploy Preview for vitest-dev ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit 755b4d9
🔍 Latest deploy log https://app.netlify.com/projects/vitest-dev/deploys/69b748a3a567a30008e76e86
😎 Deploy Preview https://deploy-preview-9870--vitest-dev.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@lishaduck lishaduck changed the title feat: support build mode feat: support typescript build mode Mar 16, 2026
@lishaduck
Copy link
Contributor Author

lishaduck commented Mar 16, 2026 •
edited
Loading

CI's just a flake, playwright test timed out. Won't waste CI on it 'nless ya ask me to :)

@lishaduck lishaduck mentioned this pull request Mar 18, 2026
Closed
3 tasks
@sheremet-va sheremet-va moved this to P2 - 4 in Team Board Mar 19, 2026
@sheremet-va sheremet-va added the p2-to-be-discussed Enhancement under consideration (priority) label Mar 19, 2026
@sheremet-va
Copy link
Member

sheremet-va commented Mar 19, 2026

Doesn't it generate files on the system?

@lishaduck
Copy link
Contributor Author

lishaduck commented Mar 19, 2026

Doesn't it generate files on the system?

Yes, that's the point. "build mode" builds the projects because they need the .d.ts built to reference them; if they're unbuilt, it errors with TypeCheckError: Output file '/.../file.d.ts' has not been built from source file '/.../file.ts'. (etc).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

p2-to-be-discussed Enhancement under consideration (priority)

Projects

Team Board
Status: P2 - 4

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Support monorepos with project references in types testing vitest typecheck does not work when TypeScript references are used with noEmit

2 participants

@lishaduck @sheremet-va