Skip to content

chore: get types tests running#2427

Closed
lishaduck wants to merge 1 commit intomainfrom
vitest-yall
Closed

chore: get types tests running#2427
lishaduck wants to merge 1 commit intomainfrom
vitest-yall

Conversation

@lishaduck
Copy link
Member

@lishaduck lishaduck commented Mar 13, 2026

PR Checklist

Overview

Trying to prove that one study right 😉
(In that amp made the first failing draft but now I wanna make it work by hand)

Note: Upstreaming "in-progress" at vitest-dev/vitest#9870.

@changeset-bot
Copy link

changeset-bot bot commented Mar 13, 2026

⚠️ No Changeset found

Latest commit: 223a99c

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@vercel
Copy link

vercel bot commented Mar 13, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
flint Ready Ready Preview, Comment Mar 13, 2026 11:37pm

Request Review

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm sure there's a reason this is designed as-is, so I'm not thrilled with patching it, but this seems to work in CI at least.

"typescript": "5.9.3",
"typescript-eslint": "8.57.0",
"vitest": "4.0.18"
"vitest": "4.0.15"
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There's quite a bit of drift, sounds to me like we should do #2296.

@lishaduck lishaduck marked this pull request as ready for review March 13, 2026 22:18
@mrazauskas
Copy link

This PR can be closed, I guess. See #2435 (review)

@auvred auvred closed this Mar 22, 2026
@auvred auvred deleted the vitest-yall branch March 22, 2026 06:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants