feat: disable colors if agent is detected#9851
Open
sheremet-va wants to merge 3 commits intovitest-dev:mainfrom
Open
feat: disable colors if agent is detected#9851sheremet-va wants to merge 3 commits intovitest-dev:mainfrom
sheremet-va wants to merge 3 commits intovitest-dev:mainfrom
Conversation
✅ Deploy Preview for vitest-dev ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
hi-ogawa
previously approved these changes
Mar 13, 2026
Contributor
hi-ogawa
left a comment
There was a problem hiding this comment.
configurable?
I don't think that's needed now
AriPerkkio
approved these changes
Mar 13, 2026
Member
AriPerkkio
left a comment
There was a problem hiding this comment.
Looks good. There's still some icon colors that are set at module load level but that's fine I think.
vitest/packages/vitest/src/node/reporters/renderers/utils.ts
Lines 20 to 28 in 731b144
RUN v4.1.0-beta.6 /x/vitest/test/config/fixtures/console-color stdout | basic.test.ts\x1B[2m > \x1B[22mconsole color true \x1B[32m✓\x1B[39m basic.test.ts (1 test) 1ms Test Files 1 passed (1) Tests 1 passed (1) Start at 22:07:30 Duration 85ms (transform 11ms, setup 0ms, import 16ms, tests 1ms, environment 0ms)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.