setTimeout() in Dialog#show() may cause miscalculation of dialog position#62
Open
fschaefer wants to merge 3 commits intovisionmedia:masterfrom
Open
setTimeout() in Dialog#show() may cause miscalculation of dialog position#62fschaefer wants to merge 3 commits intovisionmedia:masterfrom
fschaefer wants to merge 3 commits intovisionmedia:masterfrom
Conversation
The displaying of the dialog is deferred by removing the hide class in a setTimeout() call. A subsequent call to Dialog#show() might calculate a wrong dialog width due to the deferred hide class removal.
This allows the use of html as text argument in Menu#add().
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
see commit message.