-
Notifications
You must be signed in to change notification settings - Fork 2.2k
fix(core): add shader-based globe occlusion for IconLayer and TextLayer #9975
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Changes from all commits
b02957e
2ecdc9e
bab4527
9ce14bc
7d342b7
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -144,7 +144,6 @@ function App() { | |
| <> | ||
| <DeckGL | ||
| controller | ||
| parameters={{cullMode: 'back'}} | ||
|
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Removed globe culling from standalone projection test appLow Severity Removing
Collaborator
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. GlobeView.tranparent.buffer.movIf it looks like this old screen recording - I consider that a feature demo given the non interleaved config
Collaborator
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Good point. It looks like this example could be rewritten to use interleaved, or the cullMode config should be kept |
||
| views={opts.view} | ||
| initialViewState={opts.viewState} | ||
| layers={layers} | ||
|
|
||


There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Unused
globefield inLayerBuildOptionstypeLow Severity
The
globefield remains in theLayerBuildOptionstype and is still passed bybuildConfig, but the PR removed its only usage (forarcParameters) without removing the field itself.globeis never destructured or referenced inbuildLayers, making it dead code that could mislead readers into thinking globe-awareness is handled in the layer building logic.Additional Locations (1)
examples/basemap-browser/src/config/layers.ts#L38-L39