Skip to content

feat(layers) Port ColumnLayer to WebGPU#10122

Open
ibgreen wants to merge 1 commit intomasterfrom
ib/webgpu-column-layer
Open

feat(layers) Port ColumnLayer to WebGPU#10122
ibgreen wants to merge 1 commit intomasterfrom
ib/webgpu-column-layer

Conversation

@ibgreen
Copy link
Copy Markdown
Collaborator

@ibgreen ibgreen commented Mar 22, 2026

Closes #

Background

Change List

Copy link
Copy Markdown

@chatgpt-codex-connector chatgpt-codex-connector bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

modules: [project32, flatShading ? phongMaterial : gouraudMaterial, picking, columnUniforms]

P1 Badge Load the WGSL color module for ColumnLayer

In WebGPU, this layer now assembles column-layer.wgsl.ts, but that shader reads color.opacity and calls deckgl_premultiplied_alpha while getShaders() only registers project32, the material module, picking, and columnUniforms. Because no color WGSL source is included, the assembled shader has no color symbol or premultiplied-alpha helper, so creating a ColumnLayer (and therefore GridCellLayer, which subclasses it) on WebGPU fails at shader compilation time.

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

@coveralls
Copy link
Copy Markdown

Coverage Status

coverage: 91.096% (+0.03%) from 91.066%
when pulling 7dedee7 on ib/webgpu-column-layer
into e61bc7d on master.

const smoothSource = /* wgsl */ `\
${sharedSource}

struct Varyings {
Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems like a lot of repeated code, compared to the much more limited #define blocks in the GLSL

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Instead use string interpolation?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants