Fix off-by-one when setting number of ports#68
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
This PR addresses an off-by-one mismatch between the user-configured “number of ports” and the internal port table sizing by treating the configured value as the external port count and reserving an internal extra slot (port 0).
Changes:
- Initialize port/FSTP subsystems with
numports + 1to account for the internal reserved port. - Update
port/setnumportsresizing logic to allocate/resize usingval + 1internally while keeping external reporting consistent. - Adjust
port/showinfooutput to report the external port count.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| src/vde_switch/vde_switch.c | Initializes switch subsystems with an internal port count of numports + 1. |
| src/vde_switch/port.c | Introduces external-vs-internal port count handling and resizes internal tables accordingly. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
rd235
approved these changes
Mar 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.