fix: call all revalidators per key to respect individual isPaused() states#4121
Open
dcondrey wants to merge 6 commits intovercel:mainfrom
Open
fix: call all revalidators per key to respect individual isPaused() states#4121dcondrey wants to merge 6 commits intovercel:mainfrom
dcondrey wants to merge 6 commits intovercel:mainfrom
Conversation
Call all revalidators for a key to respect individual isPaused() states (vercel#2333)
Use the revalidators variable
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #2333 — when multiple components consume the same SWR key with different
isPaused()configurations, onlyrevalidators[0]was called during event revalidation. If that first revalidator belonged to a paused hook, all other (unpaused) hooks were blocked from revalidating.src/index/use-swr.ts: ExtracttriggerRevalidators()helper that iterates all registered revalidators for error retry events instead of calling onlyrevalidators[0]src/_internal/utils/mutate.ts: Call all revalidators onMUTATE_EVENTwith{ dedupe: true }so every hook gets a chance to participate while avoiding redundant fetchestest/use-swr-revalidate.test.tsx: Add tests for multi-hook isPaused scenarios, mutate with shared keys, and error retry with multiple hooksTest plan
isPaused: () => true— the unpaused hook still revalidatesmutate()triggers all revalidators for a shared key with deduplication