Skip revalidation for RSC fallback data by default#4119
Open
dcondrey wants to merge 6 commits intovercel:mainfrom
Open
Skip revalidation for RSC fallback data by default#4119dcondrey wants to merge 6 commits intovercel:mainfrom
dcondrey wants to merge 6 commits intovercel:mainfrom
Conversation
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. |
Add configuration option to skip revalidation when data comes from RSC fallback
For data coming from RSC fallback, respect revalidateOnRSCFallback option
Add revalidateOnRSCFallback default value
Create a test file to verify revalidateOnRSCFallback
Prevent the RSC fallback check from catching all fallback data. The option now only takes effect when explicitly set, preserving existing revalidation behavior for non-RSC use cases.
dcondrey
force-pushed
the
dcondrey-patch-1
branch
from
8bf6aaf to
0f3dca6
Compare
Add the revalidateOnRSCFallback guard to getSnapshot's shouldStartRequest so isValidating/isLoading correctly report false when revalidation is skipped. Add tests for backwards compatibility and SWRConfig provider fallback.
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add configuration option
revalidateOnRSCFallback(default:false) to eliminate redundant network request since data is already fresh when using SWR with RSC.Changes
revalidateOnRSCFallbacktoPublicConfigurationfalseRelated Issues
Fixes #4065