This repository was archived by the owner on Feb 16, 2026. It is now read-only.
Optimize req.method == "foo"#4438
Merged
nigoroll merged 3 commits intovarnishcache:masterfrom Jan 19, 2026
Merged
Conversation
This commit introduces the 'wkm' field in struct http, this will allow us to evaluate requests' method once with strcmp and store the result in a bitmap, effectively transforming strcmp calls into binary AND operations.
In this commit the http_SetWellKnownMethod is introduced and called on req/bereq.method initialization and modification.
cartoush
force-pushed
the
optimize_req_method
branch
from
4840ffa to
136ea89
Compare
nigoroll
approved these changes
Jan 19, 2026
Member
|
bugwash: |
Here the http_method_eq macro is updated to use the http->wkm field in order to evaluate a request's method instead of vstrcmp(). This commit also introduces the http_method_among that allows checking whether a request's method can be found in a set of well known HTTP methods.
cartoush
force-pushed
the
optimize_req_method
branch
from
136ea89 to
382ea77
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #4343
This PR optimizes VCL's req.method == "foo" by running strcmp on req.method as early as possible only once and initializing a bitmap with the result. Thanks to that the following strcmp's call are replaced with binary AND operations.