Open
Conversation
Contributor
dotstar-6
commented
Oct 30, 2024
dotstar-6
commented
- update logs browsing
- enable loki recording for statistics extraction
gquintard
reviewed
Oct 30, 2024
Collaborator
|
alright, I need more context on this, we'll need to talk about it my initial reaction is that it's a great change, even though I don't fully grasp its breadth, however I feel like it a BIG step away from a minimal demonstrator, and I'd rather have it live somewhere else, or at least have it disabled by default |
Contributor
Author
|
I concur the additions are maybe too wide to be simple. On the other hand, other monitoring components are already in and showcasing a sample usage, I think, is also beneficial. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.