Skip to content

hash: pause auto-shrink during HGETDEL #3535

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
charsyam wants to merge 1 commit into
base: unstable
Choose a base branch
from
+2 −0
Open

hash: pause auto-shrink during HGETDEL #3535

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions src/t_hash.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1173,6 +1173,7 @@ void hgetdelCommand(client *c) {
if (checkType(c, o, OBJ_HASH)) return;

bool hash_volatile_items = hashTypeHasVolatileFields(o);
if (o && o->encoding == OBJ_ENCODING_HASHTABLE) hashtablePauseAutoShrink(objectGetVal(o));

/* Reply with array of values and delete at the same time */
addReplyArrayLen(c, num_fields);
Expand All @@ -1191,6 +1192,7 @@ void hgetdelCommand(client *c) {
}
}
}
if (!keyremoved && o && o->encoding == OBJ_ENCODING_HASHTABLE) hashtableResumeAutoShrink(objectGetVal(o));

if (deleted) {
if (!keyremoved && hash_volatile_items != hashTypeHasVolatileFields(o)) {
Expand Down
Loading