Skip to content

compression: review fixes for streaming RDB compression

a241fd7
Select commit
Loading
Failed to load commit list.
Open

Streaming Compression support for RDB #3531

compression: review fixes for streaming RDB compression
a241fd7
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Apr 24, 2026 in 1s

76.73% (+0.52%) compared to 03c2d4c

View this Pull Request on Codecov

76.73% (+0.52%) compared to 03c2d4c

Details

Codecov Report

❌ Patch coverage is 92.92605% with 132 lines in your changes missing coverage. Please review.
✅ Project coverage is 76.73%. Comparing base (03c2d4c) to head (a241fd7).
⚠️ Report is 9 commits behind head on unstable.

Files with missing lines Patch % Lines
src/compression_stream.c 91.20% 35 Missing ⚠️
src/compression_rio.c 79.36% 26 Missing ⚠️
src/valkey-check-rdb.c 61.29% 24 Missing ⚠️
src/rio.c 66.66% 21 Missing ⚠️
src/rdb.c 85.71% 13 Missing ⚠️
src/compression.c 91.54% 6 Missing ⚠️
src/aof.c 78.94% 4 Missing ⚠️
src/compression_lz4.c 97.59% 2 Missing ⚠️
src/unit/test_compression.cpp 99.89% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##           unstable    #3531      +/-   ##
============================================
+ Coverage     76.21%   76.73%   +0.52%     
============================================
  Files           159      164       +5     
  Lines         81672    81858     +186     
============================================
+ Hits          62243    62815     +572     
+ Misses        19429    19043     -386     
Files with missing lines Coverage Δ
src/config.c 78.15% <100.00%> (-0.15%) ⬇️
src/rdb.h 100.00% <ø> (ø)
src/rio.h 100.00% <ø> (ø)
src/server.h 100.00% <ø> (ø)
src/unit/test_compression.cpp 99.89% <99.89%> (ø)
src/compression_lz4.c 97.59% <97.59%> (ø)
src/aof.c 80.29% <78.94%> (-0.06%) ⬇️
src/compression.c 91.54% <91.54%> (ø)
src/rdb.c 77.27% <85.71%> (+0.36%) ⬆️
src/rio.c 83.51% <66.66%> (-1.33%) ⬇️
... and 3 more

... and 121 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.