Skip to content

Test repl fix to see if test-ubuntu-latest-cmake-tls passes (forkless)#3523

Closed
asagege wants to merge 3 commits intovalkey-io:forklessfrom
asagege:test_repl_fix
Closed

Test repl fix to see if test-ubuntu-latest-cmake-tls passes (forkless)#3523
asagege wants to merge 3 commits intovalkey-io:forklessfrom
asagege:test_repl_fix

Conversation

@asagege
Copy link
Copy Markdown
Contributor

@asagege asagege commented Apr 16, 2026

Test repl fix from #3511 to see if test-ubuntu-latest-cmake-tls passes

asagege and others added 2 commits April 10, 2026 23:59
Signed-off-by: Alina Liu <liusalisa6363@gmail.com>
Signed-off-by: Sarthak Aggarwal <sarthagg@amazon.com>
@sarthakaggarwal97
Copy link
Copy Markdown
Contributor

Different tests failing till now. I think one of them was just fixed by Viktor in unstable.

@codecov
Copy link
Copy Markdown

codecov Bot commented Apr 16, 2026

Codecov Report

❌ Patch coverage is 96.71053% with 5 lines in your changes missing coverage. Please review.
✅ Project coverage is 76.59%. Comparing base (3f88d60) to head (d829261).
⚠️ Report is 2 commits behind head on forkless.

Files with missing lines Patch % Lines
src/object.c 87.50% 4 Missing ⚠️
src/server.c 66.66% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##           forkless    #3523      +/-   ##
============================================
+ Coverage     76.56%   76.59%   +0.03%     
============================================
  Files           158      158              
  Lines         79078    79183     +105     
============================================
+ Hits          60548    60654     +106     
+ Misses        18530    18529       -1     
Files with missing lines Coverage Δ
src/config.c 78.33% <ø> (ø)
src/server.h 100.00% <ø> (ø)
src/unit/test_object.cpp 99.42% <100.00%> (+0.43%) ⬆️
src/server.c 89.57% <66.66%> (+0.06%) ⬆️
src/object.c 92.36% <87.50%> (-0.19%) ⬇️

... and 18 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@asagege asagege mentioned this pull request Apr 16, 2026
Signed-off-by: Sarthak Aggarwal <sarthagg@amazon.com>
@JimB123 JimB123 changed the title Test repl fix to see if test-ubuntu-latest-cmake-tls passes Test repl fix to see if test-ubuntu-latest-cmake-tls passes (forkless) Apr 17, 2026
@asagege asagege closed this Apr 21, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants