Skip to content

[Flaky Tests] Avoid re-triggering io-thread activation#3509

Merged
madolson merged 5 commits intovalkey-io:unstablefrom
sarthakaggarwal97:fix/io-threads-flake-3504
Apr 18, 2026
Merged

[Flaky Tests] Avoid re-triggering io-thread activation#3509
madolson merged 5 commits intovalkey-io:unstablefrom
sarthakaggarwal97:fix/io-threads-flake-3504

Conversation

@sarthakaggarwal97
Copy link
Copy Markdown
Contributor

The test was accidentally waking the IO threads while trying to check that they had gone idle.

After the recent IO-thread refactor in #3324, the test started forcing io-threads-always-active, and its repeated INFO polling counted as fresh activity. So instead of just observing the worker threads, the test kept reactivating them and then flaked.

Signed-off-by: Sarthak Aggarwal <sarthagg@amazon.com>
@sarthakaggarwal97 sarthakaggarwal97 force-pushed the fix/io-threads-flake-3504 branch from 8eb2ec7 to 402049c Compare April 15, 2026 00:28
@codecov
Copy link
Copy Markdown

codecov Bot commented Apr 15, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 76.45%. Comparing base (b2d08c9) to head (253f929).
⚠️ Report is 1 commits behind head on unstable.

Additional details and impacted files
@@             Coverage Diff              @@
##           unstable    #3509      +/-   ##
============================================
+ Coverage     76.40%   76.45%   +0.05%     
============================================
  Files           159      159              
  Lines         79851    79851              
============================================
+ Hits          61008    61053      +45     
+ Misses        18843    18798      -45     

see 25 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@sarthakaggarwal97
Copy link
Copy Markdown
Contributor Author

Should get stabilized by #3511

Comment thread tests/unit/io-threads.tcl Outdated
@sarthakaggarwal97 sarthakaggarwal97 force-pushed the fix/io-threads-flake-3504 branch from 5de21ce to 7a14051 Compare April 15, 2026 17:15
@sarthakaggarwal97 sarthakaggarwal97 marked this pull request as draft April 15, 2026 17:19
Signed-off-by: Sarthak Aggarwal <25262500+sarthakaggarwal97@users.noreply.github.com>
@sarthakaggarwal97 sarthakaggarwal97 force-pushed the fix/io-threads-flake-3504 branch from 7a14051 to 8d2e280 Compare April 15, 2026 17:20
@sarthakaggarwal97 sarthakaggarwal97 marked this pull request as ready for review April 15, 2026 18:27
@madolson madolson added the run-extra-tests Run extra tests on this PR (Runs all tests from daily except valgrind and RESP) label Apr 17, 2026
@madolson madolson merged commit 109ef34 into valkey-io:unstable Apr 18, 2026
64 of 66 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

run-extra-tests Run extra tests on this PR (Runs all tests from daily except valgrind and RESP)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants