[Flaky Tests] Avoid re-triggering io-thread activation#3509
Merged
madolson merged 5 commits intovalkey-io:unstablefrom Apr 18, 2026
Merged
[Flaky Tests] Avoid re-triggering io-thread activation#3509madolson merged 5 commits intovalkey-io:unstablefrom
madolson merged 5 commits intovalkey-io:unstablefrom
Conversation
99915f2 to
8eb2ec7
Compare
Signed-off-by: Sarthak Aggarwal <sarthagg@amazon.com>
8eb2ec7 to
402049c
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## unstable #3509 +/- ##
============================================
+ Coverage 76.40% 76.45% +0.05%
============================================
Files 159 159
Lines 79851 79851
============================================
+ Hits 61008 61053 +45
+ Misses 18843 18798 -45 🚀 New features to boost your workflow:
|
Contributor
Author
|
Should get stabilized by #3511 |
Nikhil-Manglore
approved these changes
Apr 15, 2026
hpatro
reviewed
Apr 15, 2026
5de21ce to
7a14051
Compare
Signed-off-by: Sarthak Aggarwal <25262500+sarthakaggarwal97@users.noreply.github.com>
7a14051 to
8d2e280
Compare
madolson
approved these changes
Apr 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The test was accidentally waking the IO threads while trying to check that they had gone idle.
After the recent IO-thread refactor in #3324, the test started forcing
io-threads-always-active, and its repeatedINFOpolling counted as fresh activity. So instead of just observing the worker threads, the test kept reactivating them and then flaked.