Add CLIENT CAPA option for keyless read command redirection for non-readonly replicas#3505
Draft
yanamolo wants to merge 2 commits intovalkey-io:unstablefrom
Draft
Add CLIENT CAPA option for keyless read command redirection for non-readonly replicas#3505yanamolo wants to merge 2 commits intovalkey-io:unstablefrom
yanamolo wants to merge 2 commits intovalkey-io:unstablefrom
Conversation
…eadonly replicas Signed-off-by: Yana Molodetsky <yamolodu@amazon.com>
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## unstable #3505 +/- ##
============================================
- Coverage 76.48% 76.42% -0.06%
============================================
Files 159 159
Lines 79815 79857 +42
============================================
- Hits 61043 61028 -15
- Misses 18772 18829 +57
🚀 New features to boost your workflow:
|
Signed-off-by: Yana Molodetsky <yamolodu@amazon.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Introduce a new client capability
redirect-keylessthat, when set, causes keyless read commands (e.g SCAN) to be redirected to the primary with a MOVED response when the client is connected to a replica and has not opted into replica reads via READONLY.Previously, keyless commands were unconditionally excluded from cluster redirection logic. This made it impossible for smart clients to ensure all reads go to the primary without explicitly tracking which commands carry keys.
Changes:
Closes #2991