Skip to content

test(isBase64): add large-string regression tests #2681

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
easedu wants to merge 3 commits into
base: master
Choose a base branch
from
+20 −0
Open

test(isBase64): add large-string regression tests #2681

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
ca761ea
fix(isBase64): replace regex with iterative validation to prevent sta…
easedu Mar 7, 2026
309fd1b
refactor(isBase64): remove unreachable dead branch
easedu Mar 7, 2026
a962534
revert implementation, keep large-string tests only
easedu Mar 7, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 20 additions & 0 deletions test/validators/isBase64.test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -198,4 +198,24 @@ describe('isBase64', () => {
],
});
});

it('should not cause stack overflow on large strings', () => {
// Valid base64 ~1MB
const largeValid = Buffer.alloc(1000000).toString('base64');
if (!validator.isBase64(largeValid)) {
throw new Error('isBase64() failed for a large valid base64 string');
}

// Invalid: large base64 with an invalid character in the middle
const largeInvalid = `${largeValid.slice(0, 500000)}!${largeValid.slice(500001)}`;
if (validator.isBase64(largeInvalid)) {
throw new Error('isBase64() should have failed for a large invalid base64 string');
}

// URL-safe variant
const largeUrlSafe = largeValid.replace(/\+/g, '-').replace(/\//g, '_').replace(/=/g, '');
if (!validator.isBase64(largeUrlSafe, { urlSafe: true })) {
throw new Error('isBase64() failed for a large valid base64url string');
}
});
});
Loading