head: reset stale partial line state on reused buffers#11407
Open
can1357 wants to merge 1 commit intouutils:mainfrom
Open
head: reset stale partial line state on reused buffers#11407can1357 wants to merge 1 commit intouutils:mainfrom
can1357 wants to merge 1 commit intouutils:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
uutils
head -n -Non non-seekable input can leak one trailing line becauseTakeAllLinesBuffer.partial_lineis reused across fills and can staytrueafter a later terminated chunk. GNU recomputes tail state from current bytes each read; this fix resets the flag infill_bufferand adds a deterministic regression covering the non-seekable code path.Reproduction Steps
Impact
Pipelines that rely on
head -n -Nfor tail elision on non-seekable streams can silently emit data that should be suppressed. This is a correctness issue.