chcon: anchor recursive relabel resolution to traversal dirfd#11402
Open
can1357 wants to merge 1 commit intouutils:mainfrom
Open
chcon: anchor recursive relabel resolution to traversal dirfd#11402can1357 wants to merge 1 commit intouutils:mainfrom
can1357 wants to merge 1 commit intouutils:mainfrom
Conversation
|
GNU testsuite comparison: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
uutils chcon still resolved recursive targets from
fts_accpathwith a fresh path lookup, so traversal and apply were not bound to traversal directory state. GNU performs relabel operations relative to traversal dirfds; this fix opens targets withopenatagainst the traversal cwd fd before SELinux get/set.Reproduction Steps
This race is timing-sensitive and not deterministic.
Impact
Privileged recursive relabel operations can be redirected to unintended objects under rename or symlink races. This breaks GNU hardening expectations for SELinux administration workflows.