sync: fall back to full sync when --file-system has no operands#11393
Open
can1357 wants to merge 1 commit intouutils:mainfrom
Open
sync: fall back to full sync when --file-system has no operands#11393can1357 wants to merge 1 commit intouutils:mainfrom
can1357 wants to merge 1 commit intouutils:mainfrom
Conversation
|
GNU testsuite comparison: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
uutils
sync --file-systemwith no file operands enters the filesystem-sync path with an empty list and returns success without issuing any sync syscall. GNU treats this mode as a globalsync()when no operands are given.Reproduction Steps
Kind of hard to observe.
Impact
Scripts that rely on
sync --file-systemsuccess as a durability barrier can proceed without flushing data, risking data loss and GNU incompatibility.